feat: WFC3 (UVIS + IR) reduction support (phase 2) - #5
Merged
Conversation
wfc3_uvis (ACS-like: _flc, iref, native 0.0396) and wfc3_ir (_flt, no CTE, native 0.128, recommended 0.065 output); recommended_final_scale adapter field; docs/design/wfc3.md per-stage deltas + hst-lens coverage audit; 62 tests green (ACS suite untouched). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WNhuuvZLgZjHvWBGdhUst3
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WNhuuvZLgZjHvWBGdhUst3
…CS-matched cutout footprint Finite-noise guard caught zero-weight speckle at pixfrac 0.8 and a detector-defect blob 8.5" off-target inside the oversized 18.3" cutout; both dial adjustments documented in docs/design/wfc3.md. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WNhuuvZLgZjHvWBGdhUst3
…tection' pseudo-filter, doc script path The peakmax cap divided full well by mosaic-total EXPTIME, ~8x too strict on multi-exposure stacks (physically wrong for IR ramps and over-conservative for CCD stacks); now uses the longest single exposure. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WNhuuvZLgZjHvWBGdhUst3
This was referenced Jul 8, 2026
This was referenced Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements WFC3 (UVIS + IR) support per #4, rebased onto
mainafter PR #3 merged. Autonomous run (--autosupervised), parked at ship sign-off.What this adds
instruments/wfc3_uvis.py— the ACS-like path:_flcCTE-corrected,iref/references/hst/wfc3, native 0.0396″/pix (also the recommended output scale), 63 ke- full well.instruments/wfc3_ir.py— the different path:_flt(no CTE correction; up-the-ramp CR rejection), native 0.128″/pix with recommended 0.065″ output, 78 ke- full well.InstrumentAdapter.recommended_final_scale— adapter-owned sampling recommendation;TargetSpec.final_scalestays the user dial (ACS default unchanged).docs/design/wfc3.md— per-stage deltas vs ACS, the hst-lens notebook coverage audit, and two integration findings (below); roadmap section ticked to in-progress.scripts/reduce_j0252_wfc3.py— both channels on SDSS J0252+0039.Integration results (real MAST data)
Two loud-failure demonstrations (the guards working as designed, both documented in
wfc3.md): IR at pixfrac 0.8 left zero-weight speckle → guard refused to package; and the oversized 18.3″ cutout clipped a detector-defect blob 8.5″ off-target → matched to the ACS 14″ sky footprint (215 px at 0.065″).API Changes
New adapters
wfc3_uvis,wfc3_ir; newInstrumentAdapter.recommended_final_scalefield (defaulted — existing adapter construction unaffected). No other PyAuto* repo touched.Scripts Changed
New
scripts/reduce_j0252_wfc3.py(UVIS anchor validation + IR discovery/validation). Design docs updated.Gate legs (supervised — parked at sign-off)
🤖 Generated with Claude Code
https://claude.ai/code/session_01WNhuuvZLgZjHvWBGdhUst3